Skip to content

FOUR-9372 - Show default screen for display and form tasks#5011

Merged
ryancooley merged 11 commits into
developfrom
feature/FOUR-9372
Jul 21, 2023
Merged

FOUR-9372 - Show default screen for display and form tasks#5011
ryancooley merged 11 commits into
developfrom
feature/FOUR-9372

Conversation

@eiresendez
Copy link
Copy Markdown
Contributor

@eiresendez eiresendez commented Jul 18, 2023

Issue & Reproduction Steps

The default screens will be displayed when the user doesn't select a screen in the Modeler for a Form or Manual task. It will also be displayed when there's no reference to a screen or when a screen does not exist.

Solution

  • The screens were generated using the ScreenBuilder according to the Figma mockup.
  • The screens were exported and the JSON files were stored in database/processes/screens.
  • The default system screens were installed by running the seeder php artisan db:seed --class="ScreenSystemSeeder".
  • The default screen is obtained if necessary and whether it's a manual or form task.
  • It also works for nested screens.
  • It also works for web entry tasks and start event.

How to Test

  • Please run the seeder: php artisan db:seed --class="ScreenSystemSeeder" and execute manual tests.
  • Execute manual tests in the provided QA server.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:package-webentry:feature/FOUR-9372

@eiresendez
Copy link
Copy Markdown
Contributor Author

Examples:

example-default-display-screen
example-default-form-screen

@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-2f28fcef16.eng.processmaker.net

@eiresendez
Copy link
Copy Markdown
Contributor Author

Example for Nested Screens:

example-default-nested-screen

@eiresendez eiresendez requested a review from nolanpro July 18, 2023 22:42
@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-2f28fcef16.eng.processmaker.net

@eiresendez
Copy link
Copy Markdown
Contributor Author

Example for Web Entry:

Screen Shot 2023-07-19 at 11 12 24 a m

@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-2f28fcef16.eng.processmaker.net

@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-2f28fcef16.eng.processmaker.net

@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-2f28fcef16.eng.processmaker.net

@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-2f28fcef16.eng.processmaker.net

@processmaker-sonarqube
Copy link
Copy Markdown

@tokensPM
Copy link
Copy Markdown

QA server was successfully deployed https://ci-2f28fcef16.eng.processmaker.net

@ryancooley ryancooley merged commit 7365c19 into develop Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants